search

axiomhq / cli

The power of Axiom on the command line.
https://axiom.co
MIT License
41 stars 11 forks source link

error display fix, processedBytes less misleading #138

Closed s-scheele-simonsen closed 2 years ago

s-scheele-simonsen commented 2 years ago

We weren't displaying errors correctly, e.g.:

Mon, 08 Aug 2022 07:51:34 CEST: %!s(<nil>)

Added a processedBytes line separately, due to potential misleading data (due to processedBytes counting failed and successful events combined):

✓ Ingested 9 events (1.2 MB) // <--total size wrong, should be couple kbs ✖ Failed to ingest 1 event: // <-- this one is 1.2 MB large.

If anyone has a better idea of how to display the processed bytes, e.g. wording, placement, all feedback is welcome.

codecov[bot] commented 2 years ago

Codecov Report

Base: 14.10% // Head: 15.25% // Increases project coverage by +1.15% :tada:

Coverage data is based on head (0c615a8) compared to base (3637b5a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #138 +/- ## ========================================== + Coverage 14.10% 15.25% +1.15% ========================================== Files 10 10 Lines 539 793 +254 ========================================== + Hits 76 121 +45 - Misses 445 654 +209 Partials 18 18 ``` | [Impacted Files](https://codecov.io/gh/axiomhq/cli/pull/138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq) | Coverage Δ | | |---|---|---| | [pkg/terminal/io.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-cGtnL3Rlcm1pbmFsL2lvLmdv) | `0.00% <0.00%> (ø)` | | | [internal/cmd/root/help.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-aW50ZXJuYWwvY21kL3Jvb3QvaGVscC5nbw==) | `0.00% <0.00%> (ø)` | | | [internal/cmd/root/root.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-aW50ZXJuYWwvY21kL3Jvb3Qvcm9vdC5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/terminal/epipe\_other.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-cGtnL3Rlcm1pbmFsL2VwaXBlX290aGVyLmdv) | `0.00% <0.00%> (ø)` | | | [internal/cmd/root/help\_topic.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-aW50ZXJuYWwvY21kL3Jvb3QvaGVscF90b3BpYy5nbw==) | `100.00% <0.00%> (ø)` | | | [internal/config/config.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-aW50ZXJuYWwvY29uZmlnL2NvbmZpZy5nbw==) | `6.14% <0.00%> (+0.87%)` | :arrow_up: | | [pkg/terminal/color.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-cGtnL3Rlcm1pbmFsL2NvbG9yLmdv) | `5.26% <0.00%> (+1.00%)` | :arrow_up: | | [cmd/axiom/main.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-Y21kL2F4aW9tL21haW4uZ28=) | `19.10% <0.00%> (+1.06%)` | :arrow_up: | | [pkg/doc/doc.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-cGtnL2RvYy9kb2MuZ28=) | `76.19% <0.00%> (+1.19%)` | :arrow_up: | | [pkg/terminal/table\_printer.go](https://codecov.io/gh/axiomhq/cli/pull/138/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq#diff-cGtnL3Rlcm1pbmFsL3RhYmxlX3ByaW50ZXIuZ28=) | `49.41% <0.00%> (+2.24%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=axiomhq)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lukasmalkmus commented 2 years ago

Thanks, great PR!