search

axiomhq / cli

The power of Axiom on the command line.
https://axiom.co
MIT License
42 stars 11 forks source link

client: support HTTPS_PROXY and HTTP_PROXY #170

Closed tsenart closed 1 year ago

tsenart commented 1 year ago

This commit adds support for the standard HTTPS_PROXY and HTTP_PROXY env vars, which allows inspection of HTTP requests with proxies such as mitmproxy, aiding debugging.

lukasmalkmus commented 1 year ago

Damn. If I had noticed how simple this change is, I would have gotten to it way faster. Sorry!

One tiny thing: Can you add documentation for the env vars to the bottom of the environment help topic in https://github.com/axiomhq/cli/blob/main/internal/cmd/root/help_topic.go#L23-L49?

tsenart commented 1 year ago

@lukasmalkmus: Done. PTAL.

tsenart commented 1 year ago

Please squash commits before merging or let me merge.

tsenart commented 1 year ago

@lukasmalkmus: I think you need to leave an approving review, or this won't merge.

lukasmalkmus commented 1 year ago

@lukasmalkmus: I think you need to leave an approving review, or this won't merge.

I thought I did that 🤦 GitHub wouldn't let me approve for some reason before I left... Anyways... done now. Will cut a hot fix release.