search

axiomzen / zest

Tests with a twist
2 stars 0 forks source link

Custom Build Containers #31

Closed chrisaxiom closed 7 years ago

chrisaxiom commented 7 years ago

I am not sure the direction to go with this one. If we need custom tools in the build container that will be there every time, it would make sense to build that image from a Dockerfile so that you don't have to install yarn every time (for example). The two options are:

a) Host our custom monstrosity on DockerHub b) Give zest the ability to build a custom build container based on a Dockerfile you give it.

@AndrewBurian what are your thoughts?

chrisaxiom commented 7 years ago

An annoyance with b) is that the .dockerignore has to be temporarily removed so that the files can be copied in... hmm

chrisaxiom commented 7 years ago

Multi-stage builds resolve this now