axiomzen / zest

Tests with a twist
2 stars 0 forks source link

Feed git commit hash through a Revision env var to container #45

Closed chrisaxiom closed 6 years ago

chrisaxiom commented 6 years ago

BUILD_ARGS have been added but they won't work with an actual docker --build-arg VAR=$VAR.

The one that has been useful for other projects is the git hash, so I am going to add it via a new Revision() function in the zest file. Already added to hatch here.

chrisaxiom commented 6 years ago

Possible with current setup via quotes:

zest build -b "--build-arg VAR=$VAR"

chrisaxiom commented 6 years ago

Actually, might be useful as a default --build-arg