search

axiondarkmatterexperiment / dripline-orpheus

1 stars 1 forks source link

standardize variable names: resonator or cavity #17

Open raphaelcervantes opened 4 years ago

raphaelcervantes commented 4 years ago

Some variables refer to cavity and some variables refer to resonators. We should standardize to avoid confusion.

I think I am now prefer cavity.

This is a message I sent to Gray.

Regarding nomenclature: I found out that people also refer to a Fabry-Perot resonator as a cavity: https://www.rp-photonics.com/optical_resonators.html And now that I think about it, I'm pretty sure LIGO refers to their stuff as cavities (e.g. reference cavity). I feel like I want to go back to calling things cavities because it's a tongue-twister for me to talk about resonances of resonators.

parasharmohapatra commented 4 years ago

ok currently I think everything is set to resonator. I can change it if you would like

raphaelcervantes commented 4 years ago

https://github.com/axiondarkmatterexperiment/dripline-orpheus/blob/master/data_taking_scripts/motor.py#L118

motor.py has references to cavity.

Also Gray replied back

Ok, that's fine. I tried to expand my vocabulary to resonator in case I wanted to get into photonic bandgap structures or something even weirder.

raphaelcervantes commented 4 years ago

Let me think about what I prefer.

raphaelcervantes commented 2 years ago

Settled on cavity, but not sure if I have fixed all the variables yet.