search

axiros / terminal_markdown_viewer

Styled Terminal Markdown Viewer
Other
1.81k stars 106 forks source link

'unichr' still in pip package #55

Open kBite opened 7 years ago

kBite commented 7 years ago

Hey,

I'm experiencing the same issue like #46 with current pip package: mdv (1.6.3)

$ mdv --help
Option parsing error
Traceback (most recent call last):
...
  File "/home/user/.local/lib/python3.5/site-packages/mdv/markdownviewer.py", line 624, in replace_links
    cur += '%s ' % unichr(link_start_ord + cur_link)
NameError: name 'unichr' is not defined

When I manually replace unichr with chr it works like a charm.

I saw your change 834bfd8 in #46 but this hasn't made it downstream yet. Please update the pip package.

ghost commented 6 years ago

Same experience here.

robbiemorrison commented 6 years ago

Same experience here. Using:

Can you not write some version specific code? Also why was this issue closed on 16 August 2017? It should be reopened surely. .. Actually, maybe it is not closed.

clampak commented 6 years ago

This error still exists for me.

MikeSperone commented 6 years ago

Still not in the pip package I got today (I also updated my pip and tried to upgrade mdv again, neither of which helped).

OS: Mac 10.11.6 (El Capitan) python: 3.6.4 pip: 9.0.2

atomic commented 6 years ago

Confirmed on: