feat: Allow toggling autoclose

ditsuke commented 1 year ago

Summary

Adds a command to allow toggling autoclose on the fly.
Also gives autoclose the ability to close multiple buffers, to the point where we reach the open buffer threshold or exhaust closeable buffers. This is necessitated by the ability to toggle autoclose.

Note

Please review #2 before this PR.

axkirillov commented 1 year ago

Since I rebased your other pr on top of main those 2 commits got rehashed. Just delete them and force push to get rid of conflicts.

Could you also update the README.md to mention the new toggle_autoclose command?

axkirillov commented 1 year ago

Looks great! @al-ce do you wanna take a look? I think it touches some of your code.

al-ce commented 1 year ago

Looks great! @al-ce do you wanna take a look? I think it touches some of your code.

Great PR! I tested it real quick for the sake of an extra eye, works well and I can't find any issues on a quick test. Don't know that I have anything more constructive to add so I'll just comment from a user perspective. The pin commands work as I would expect as when autoclosing is toggled off and then are toggled back on. I very much like the feature to prevent visible ~~windows~~ buffers from being auto closed.

I don't want this to hold up the deployment but maybe in a future commit you could explain in the README why a user might want to customize the close_command. I can think of some creative use cases but maybe not what was intended for allowing this new option. Thanks for the new features @ditsuke !

axkirillov commented 1 year ago

Do you wanna rebase anyhting? Otherwise, I'll just merge it as is

ditsuke commented 1 year ago

Squashed down to 4 commits. Thanks for approving @axkirillov @al-ce :rocket:

axkirillov / hbac.nvim

feat: Allow toggling autoclose #3

Summary

Note