axkr / symja_android_library

:coffee: Symja - computer algebra language & symbolic math library. A collection of popular algorithms implemented in pure Java.
https://matheclipse.org/
GNU General Public License v3.0
375 stars 84 forks source link

Inverse hyperbolic functions are usually called "area functions" #292

Closed HannesWell closed 2 years ago

HannesWell commented 2 years ago

Describe the bug

Unlike the inverse of ordinary trigonometric functions (like sin, cos, ...) that are usually called arcus functions the inverse functions of the hyperbolic functions (like sinh, cosh, ...) are usually called area functions.

Therefore the mathematical symbol is usually the name of the corresponding hyperbolic function prefixed with ar-, for trigonometric functions it is usually arc-. Unfortunately Symja also uses the arc- prefix for the inverse hyperbolic functions which does not comply with the usual mathematical notation. The Symbols in class S, the corresponding factory methods in class F and the evaluator classes in ExpTrigsFunctions should be renamed the following way:

I hope I did not forget any location.

axkr commented 2 years ago

The Symja functions names are compatible with the Mathematica function names.

For example:

For this reason the general renaming should be avoided.

There are however already existing aliases which could be extended:

HannesWell commented 2 years ago

OK, understand that. Since we use Symja directly from code and not via the notebooks the aliases do not affect us (or am I wrong with the assumtion that they are only considered by the parser). If the notebook language is intended to be Mathematica compatible it could be done the other way round: Name the methods and classes like the usual convention and add aliases for the Mathematica names.

However this is just cosmetic and has no functional advantage because the intention of the methods is clear how they are, even it is not the usual (at least what Wikipedia says) mathematical convention.

axkr commented 2 years ago

Yes the aliases are used in the parsers.

hakanai commented 2 years ago

More often than not, in code, the prefix for these is just a-.

axkr commented 2 years ago

More often than not, in code, the prefix for these is just a-.

Yes the ALIASES_STRINGS are named like this