axmor / typecs

TypEcs - TypeScript IDE for Eclipse
61 stars 14 forks source link

Modified 'isTargetRelativePathBasedOnSource' algorithm to use TypeScr… #86

Closed RasPelikan closed 9 years ago

RasPelikan commented 9 years ago

…ipt 1.5 feature 'rootDir'

We experienced a broken output. We use "relative paths" and at some circumstances (it seems at random, but reproduce-able) the output directories were mixed up. After a little bit of google-ing I found this bug-report: https://github.com/Microsoft/TypeScript/issues/812. The issue was solved by this pull-request: https://github.com/Microsoft/TypeScript/pull/2772. It was solved by adding a new parameter "rootDir" which can be used for building output-paths as relative paths based on this root directory under which the files to be compiled are placed. As this matches the typecs-plugin's feature 'Set relative path from target directory to output file based on relative path from source directory to input file' I re-factored this feature to use the new "rootDir" parameter instead of calculating the relative path by the plugin. This fixed our broken output.