axmszr / pe

0 stars 0 forks source link

Invalid dates that follow the format still have the same format error message #10

Open axmszr opened 1 year ago

axmszr commented 1 year ago

Summary:

If a date is valid format-wise, but invalid (e.g. 29 Feb on a non-leap year), an unhelpful error message is returned.

Steps:

  1. Call deadline task/12398 by/29/02/2023 to see the error message.

Image:

image.png

nus-pe-bot commented 1 year ago

Team's Response

Agreed it is an issue and couldnt be solved due to feature freeze

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message does not reflect the issue

How to reproduce: deadline task/Complete Assignment 4 by/30/02/2024

Problem: when I type in a weird date, it throws an error, which states that the dates should be a certain format. However, it doesnt say that the error is in the invalid date.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#3775] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Agreed that error message could be more specific but was not allowed due to feature freeze

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** the website says this should be a feature flaw: ![image.png](https://raw.githubusercontent.com/axmszr/pe/main/files/032f7ad0-1b3e-4fed-b9b6-c0354f67e5d3.png) sorry! made a mistake in the original PE phase.