axmszr / pe

0 stars 0 forks source link

Event error message is not helpful for events with to/DATE less than from/DATE #11

Open axmszr opened 1 year ago

axmszr commented 1 year ago

Summary:

Calling a to/DATE that comes before the from/DATE returns an unhelpful error message.

Steps:

  1. Call event task/123abc from/14/04/2023 to/13/04/2023 to see the order error message.

Image:

image.png

nus-se-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error message does not reflect the issue

How to reproduce: deadline task/Complete Assignment 4 by/30/02/2024

Problem: when I type in a weird date, it throws an error, which states that the dates should be a certain format. However, it doesnt say that the error is in the invalid date.

image.png


[original: nus-cs2103-AY2223S2/pe-interim#3775] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Agreed that error message could be more specific but was not allowed due to feature freeze

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While these both fall under error messages for date, these are two separate issues. The 'original' bug is an error message for incorrect dates (30th Feb) whereas this bug is an error message for an incorrect order of dates. They can most definitely be fixed independently of each other.

image.png


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** Oops, this should be a Feature Flaw. According to the CS2103 website, the specificity of error messages falls under `type.FeatureFlaw`: ![image.png](https://raw.githubusercontent.com/axmszr/pe/main/files/c5c02845-7ce4-469c-81bf-c56a8449d1c1.png)