Closed Gankra closed 1 week ago
For setting the commit in a same-repo context, we can probably use GITHUB_SHA
. It's the specific commit that created the actions run, resolved at the time the action began. The ref is also provided, but since that can get theoretically targeted midflight, GITHUB_SHA
is more specifically what we want.
working on fixing the release atomicity and ensuring it targets the right commit
atomicity:
the create command just takes the artifacts to upload. weirdly the edit command doesn't but that's ok because we only use edit for draft-release-workflows where spewing some random artifacts onto a draft that can be deleted is ~fine (the undraft happens last)
targetting commit (relevant for workflow-dispatch flow):
we also already pass --target for the submodule flow, so we just need to change that to being unconditional, and write some logic to get the current repo commit instead of the submodule