search

axodotdev / cargo-dist

📦 shippable application packaging
https://axodotdev.github.io/cargo-dist/
Apache License 2.0
1.48k stars 66 forks source link

CI: `host` job doesn't depend on success of custom build jobs #919

Open connec opened 6 months ago

connec commented 6 months ago

It's not clear if this is intentional behaviour or not, but the condition for the host GitHub Actions job does not depend on the outcome of any custom build jobs:

https://github.com/axodotdev/cargo-dist/blob/5e7826f7b09a64e5ba9edc16dab8cee7b13daa27/cargo-dist/templates/ci/github_ci.yml.j2#L392-L394

Gankra commented 6 months ago

That does indeed seem not-quite-right. I know this condition has gone through a lot of evolution, and has some really specific subtleties around the publish-a-library-which-skips-the-build-steps-but-still-runs-later-steps usecase.

This condition also used to have to handle the global step not existing, but we kinda-recently made changes that made the global step always appear in the graph.

...all that said I think it is accurate to say this should be considering custom local and global build jobs.