sarahghp
commented
1 year ago Having dug into the "proper reusable action" thing (some notes here: https://github.com/axodotdev/sarah-action/issues/1, a bunch of runs here: https://github.com/axodotdev/sarahs-playground/actions), my proposal is that we — don't.
Essentially, the reusable actions do not work with the workflow triggers we need, so users would have to use our action in workflows that have the triggers and we would therefore have to give examples of how to write them. Since that is the case (and since we still would have permissions issues, which are very limited in reusable actions), I propose for an MVC we have folks copy the files.
That would leave us with the following tasks to completion:
- Be sure the webapp is always calling the correct workflow based on the repo in which the action is installed. (I think so, but we should confirm.)
- Clean up the existing files
- One more UI thing — making the greens align.
WDYT?
Don't really fully understand the implications of this but presumably this is better than "copy these files into your CI, hope you never have to update them!".