axoflow / axosyslog

AxoSyslog - the scalable security data processor
https://axoflow.com
Other
55 stars 17 forks source link

`opentelemetry()` source crashes when config init fails #316

Open alltilla opened 2 months ago

alltilla commented 2 months ago

AxoSyslog

Version of AxoSyslog

4.8.1

Configuration

log {
  source { opentelemetry(); tcp(); };
};

Input and output logs

[2024-09-30T12:35:51.551556] Running application hooks; hook='6'
[2024-09-30T12:35:51.551556] Running application hooks; hook='7'
[2024-09-30T12:35:51.551556] OpenTelemetry server accepting connections; port='4317'
[2024-09-30T12:35:51.551556] Trying to open module; module='syslogformat', filename='/home/alltilla/repos/axosyslog/build/install/lib/syslog-ng/libsyslogformat.so'
[2024-09-30T12:35:51.551556] Module loaded and initialized successfully; module='syslogformat'
[2024-09-30T12:35:51.551556] Error binding socket; addr='AF_INET(0.0.0.0:514)', error='Permission denied (13)'
[2024-09-30T12:35:51.551556] Error initializing message pipeline; plugin_name='tcp', location='/home/alltilla/repos/axosyslog/build/install/etc/syslog-ng.conf:2:29'
E0930 12:35:51.590174963  257709 completion_queue.cc:247]    assertion failed: queue.num_items() == 0
fish: Job 1, './install/sbin/syslog-ng -Fedtv' terminated by signal SIGABRT (Abort)
MrAnno commented 1 month ago

According to the gRPC docs, shutdown should be called only after we drained the completion queues.

This may happen even in normal cases, when init does not fail.