search

axolotl-ai-cloud / axolotl

Go ahead and axolotl questions
https://axolotl-ai-cloud.github.io/axolotl/
Apache License 2.0
7.85k stars 864 forks source link

fix: phi system prompt #1844

Closed JohanWork closed 2 months ago

JohanWork commented 2 months ago

Description

The current prompt format for phi is missing <|end|> in the end of the system message. Se here

Motivation and Context

The current format is incorrect since <|end|> is missing in the end of the system message.

How has this been tested?

Added some new tests for the prompt

Screenshots (if appropriate)

Types of changes

Social Handles (Optional)

winglian commented 2 months ago

@JohanWork Do you need any help with this PR? thanks!

JohanWork commented 2 months ago

I had added it again here https://github.com/axolotl-ai-cloud/axolotl/pulls sorry for making it a bit messy. Wanted to run som more test.