The following distinct but related vulnerabilities have been identified and manually verified by the team.
BlockedAddress Input Validation: This issue involves insufficient validation mechanisms for BlockedAddress entries. The lack of rigorous validation allows for the potential misuse of blockchain resources, compromising the security of transactions.
Sanity Checks for PeriodicVestingAccount: In msg_server.go, this vulnerability arises from inadequate sanity checks during the creation of a PeriodicVestingAccount. Specifically, the system does not correctly handle cases where EndTime values are negative or overflow, which can result in system crashes or undefined behavior.
Faulty GRPC Query Tally: In grpc_query.go, the query for a failed proposal tally incorrectly attempts to tally votes anew instead of fetching the final tally result from proposal.FinalTallyResult, after votes have been removed post-failure. This results in inaccurate or impossible query responses.
Recommendation
The vesting module should refer to the correct upstream repository of cosmossdk/x/auth/vesting to ensure all security patches are correctly applied.
Description
The following distinct but related vulnerabilities have been identified and manually verified by the team.
PeriodicVestingAccount: Inmsg_server.go, this vulnerability arises from inadequate sanity checks during the creation of aPeriodicVestingAccount. Specifically, the system does not correctly handle cases whereEndTimevalues are negative or overflow, which can result in system crashes or undefined behavior.grpc_query.go, the query for a failed proposal tally incorrectly attempts to tally votes anew instead of fetching the final tally result from proposal.FinalTallyResult, after votes have been removed post-failure. This results in inaccurate or impossible query responses.Recommendation
The vesting module should refer to the correct upstream repository of
cosmossdk/x/auth/vestingto ensure all security patches are correctly applied.References