Closed amimart closed 1 month ago
The recent changes in the app
package enhance the clarity of how the GovKeeper
is managed within the New
function. By modifying the way the legacy router is set, the code now references an intermediary variable, improving readability without altering the overall functionality. This refactor aims to streamline the control flow associated with the GovKeeper
, ensuring better maintainability while preserving existing hooks.
Files | Change Summary |
---|---|
app/app.go |
Updated the method of setting the legacy router in GovKeeper , enhancing clarity without altering functionality. |
In the code where rabbits play,
A change was made to brighten the day.
TheGovKeeper
now shines so bright,
With clearer paths and logic right.
Hops of joy in refactor's dance,
Let’s celebrate this code romance! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
@@ Coverage Diff @@
## main #707 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 74 74
Lines 2906 2906
=======================================
Hits 1576 1576
Misses 1234 1234
Partials 96 96
At the initialisation of the governance module the legacy router responsible of executing legacy
v1beta1
proposals wasn't properly set causing the legacy proposal to be unsupported.Summary by CodeRabbit
GovKeeper
assignment in the app's initialization process.