Closed amimart closed 1 month ago
The recent changes enhance the query.proto
file in the logic.v1beta2
package by integrating with the Cosmos SDK's query capabilities. Key updates include a new import statement and modifications to the Params
and Ask
RPCs, marking them as safe for module queries. These improvements aim to bolster the safety and interoperability of the QueryService
within the Cosmos framework, ensuring reliable operations without side effects.
File | Change Summary |
---|---|
proto/logic/v1beta2/query.proto |
Added import for "cosmos/query/v1/query.proto" . Updated Params and Ask RPCs to include option (cosmos.query.v1.module_query_safe) = true; . |
In the meadow where queries play,
A safe path now lights the way.
With Cosmos' whispers, we take our stand,
Making sure all queries are grand!
Hooray for the changes, let joy reside,
In our hopping hearts, let safety guide! πβ¨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 54.42% 54.42%
=======================================
Files 73 73
Lines 2901 2901
=======================================
Hits 1579 1579
Misses 1228 1228
Partials 94 94
Allow to use logic module queries from ICA module safe query by marking them as safe.
Summary by CodeRabbit
Params
andAsk
queries within theQueryService
to ensure safer execution in the Cosmos module context.These changes elevate the operational safety and compatibility of the query service within the broader Cosmos framework.