Chore/upgrade golangci-lint to 1.61

dangogh commented 1 month ago

Upgraded golangci-lint to 1.61
Added comments to ignore some lint warnings (in particular gosec:G115)
Renamed min,max which are predeclared funcs as of Go 1.21
linter exportloopref deprecated -- should be replaced with copyloopvar on upgrading to Go 1.22

Summary by CodeRabbit

New Features
- Updated Docker image version for improved linting tools.
- Introduced a new job for linting proto files and enhanced existing linting jobs for better validation.
- Added unit tests for validating bounds in the validateBounds function.
Bug Fixes
- Enhanced error handling in the QueryInterpreter function.
Documentation
- Added comments to suppress specific linting warnings across various functions for clarity.
Refactor
- Renamed parameters in the validateBounds function for better readability.
- Minor adjustments to error messages for improved clarity.

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request includes updates to the Makefile and various test files primarily focused on linting adjustments and minor modifications to the build process. Key changes involve updating the Docker image version for GolangCI Lint and adding comments to suppress specific linter warnings across several files. Additionally, the validateBounds function's parameter names have been updated for clarity. Overall, the changes enhance code quality without altering the core functionality or logic.

Changes

File	Change Summary
Makefile	Updated `DOCKER_IMAGE_GOLANG_CI` from `v1.56` to `v1.61`; added conditional static linking flags.
.github/workflows/lint.yml	Updated `lint-go` job to use `golangci-lint-action` v1.61; added command to install `jsonlint`; modified `lint-proto` to find changed proto files; expanded `lint-generated` with documentation generation steps.
x/logic/keeper/features_test.go	Added comment to suppress linter warning G115 for `limit` variable.
x/logic/keeper/grpc_query_ask_test.go	Added comment to suppress linter warning G115 for `v` variable in `TestGRPCAsk`.
x/logic/keeper/interpreter.go	Added comments to suppress linter warning G115 in `execute` and `newInterpreter` methods.
x/logic/predicate/string.go	Added comments to suppress linter warning G115 for `maxLength`, `totalLen`, and return statement.
x/logic/prolog/option.go	Added comment to suppress linter warning `nilnil` in `extractOption` function.
x/logic/util/prolog.go	Modified error handling in `QueryInterpreter` to include comment for linter warning `govet`.
x/mint/simulation/proposals.go	Added comment to suppress linter warning G115 for `params.BlocksPerYear`.
x/mint/types/params.go	Renamed `validateBounds` parameters from `min, max` to `minBound, maxBound` and updated error messages.
x/mint/types/params_test.go	Added unit tests for `validateBounds` function, including various test cases for validation.

Possibly related PRs

756: The changes in the x/logic/keeper/grpc_query_ask_test.go file involve modifications to test cases related to gas limits, which may indirectly relate to the build process and linting improvements in the main PR, as both involve code quality and execution efficiency.

Suggested reviewers

amimart
bdeneux

Poem

🐰 In the garden of code, we hop and play,
With linting whispers guiding our way.
Docker images fresh, like morning dew,
Comments to silence the warnings anew.
A dance of parameters, clearer and bright,
In our code's little world, everything's right! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
x/logic/util/prolog.go	0.00%	1 Missing :warning:

@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   54.98%   55.42%   +0.43%     
==========================================
  Files          73       73              
  Lines        2966     2966              
==========================================
+ Hits         1631     1644      +13     
+ Misses       1241     1228      -13     
  Partials       94       94

Files with missing lines	Coverage Δ
x/logic/keeper/interpreter.go	`92.92% <100.00%> (ø)`
x/logic/predicate/string.go	`81.69% <100.00%> (ø)`
x/logic/prolog/option.go	`60.97% <ø> (ø)`
x/mint/simulation/proposals.go	`100.00% <100.00%> (ø)`
x/mint/types/params.go	`21.66% <100.00%> (+21.66%)`	:arrow_up:
x/logic/util/prolog.go	`0.00% <0.00%> (ø)`

axone-protocol / axoned