Closed ccamel closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
@@ Coverage Diff @@
## main #779 +/- ##
===========================================
- Coverage 55.42% 41.79% -13.63%
===========================================
Files 73 108 +35
Lines 2966 5024 +2058
===========================================
+ Hits 1644 2100 +456
- Misses 1228 2813 +1585
- Partials 94 111 +17
The pull request updates various workflow configurations and code files to transition the Go version from 1.21
to 1.23
. It introduces new jobs for linting JSON files and checking test modifications, while existing jobs are modified to reflect the new Go version. Additionally, configuration files are updated to align with the new Go version and dependencies. Test files have been enhanced with new test cases to improve coverage and clarity, particularly for vesting accounts and other functionalities.
File(s) | Change Summary |
---|---|
.github/workflows/build.yml , .github/workflows/lint.yml , .github/workflows/test-e2e.yml , .github/workflows/test.yml |
Go version updated from 1.21 to 1.23 . New jobs lint-json and check-tests added. Existing jobs modified to use the new Go version. |
.golangci.yml , Dockerfile , Makefile , go.mod , README.md |
Linter updated in .golangci.yml , Dockerfile base image and package versions updated, Makefile variable and command modified, Go version updated in go.mod , README updated for Go version requirement. |
cmd/axoned/cmd/genaccount_test.go , x/mint/client/cli/query_test.go , x/mint/keeper/msg_server_test.go , x/vesting/client/cli/tx_test.go , x/vesting/types/vesting_account_test.go |
Enhanced test coverage with new test cases added across various test files, including handling edge cases for vesting accounts and streamlining existing tests. |
.github/workflows/lint.yml
in the main PR are directly related to the updates made in the same file in PR #776, which also involves modifications to linting jobs and the introduction of the lint-json
job.🐇 In the meadow, the code does bloom,
With Go version1.23
, we make room.
New tests added, coverage wide,
Linting JSON, our skills we pride.
Hopping along, we code with glee,
A brighter future, for you and me! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This PR updates the project to use Go 1.23 and also upgrades gofumpt to version v0.7.0.
Additionally, the golangci-lint configuration has been adjusted by removing exportloopref (no longer needed since Go 1.22) and replacing it with copyloopvar.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores