axone-protocol / axoned

⛓️ Axone blockchain 💫
https://axone.xyz
Apache License 2.0
164 stars 127 forks source link

Chore/go 1.23 #779

Closed ccamel closed 1 month ago

ccamel commented 1 month ago

This PR updates the project to use Go 1.23 and also upgrades gofumpt to version v0.7.0.

Additionally, the golangci-lint configuration has been adjusted by removing exportloopref (no longer needed since Go 1.22) and replacing it with copyloopvar.

Summary by CodeRabbit

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #779       +/-   ##
===========================================
- Coverage   55.42%   41.79%   -13.63%     
===========================================
  Files          73      108       +35     
  Lines        2966     5024     +2058     
===========================================
+ Hits         1644     2100      +456     
- Misses       1228     2813     +1585     
- Partials       94      111       +17     

see 36 files with indirect coverage changes

coderabbitai[bot] commented 1 month ago

Walkthrough

The pull request updates various workflow configurations and code files to transition the Go version from 1.21 to 1.23. It introduces new jobs for linting JSON files and checking test modifications, while existing jobs are modified to reflect the new Go version. Additionally, configuration files are updated to align with the new Go version and dependencies. Test files have been enhanced with new test cases to improve coverage and clarity, particularly for vesting accounts and other functionalities.

Changes

File(s) Change Summary
.github/workflows/build.yml, .github/workflows/lint.yml, .github/workflows/test-e2e.yml, .github/workflows/test.yml Go version updated from 1.21 to 1.23. New jobs lint-json and check-tests added. Existing jobs modified to use the new Go version.
.golangci.yml, Dockerfile, Makefile, go.mod, README.md Linter updated in .golangci.yml, Dockerfile base image and package versions updated, Makefile variable and command modified, Go version updated in go.mod, README updated for Go version requirement.
cmd/axoned/cmd/genaccount_test.go, x/mint/client/cli/query_test.go, x/mint/keeper/msg_server_test.go, x/vesting/client/cli/tx_test.go, x/vesting/types/vesting_account_test.go Enhanced test coverage with new test cases added across various test files, including handling edge cases for vesting accounts and streamlining existing tests.

Possibly related PRs

Suggested reviewers

Poem

🐇 In the meadow, the code does bloom,
With Go version 1.23, we make room.
New tests added, coverage wide,
Linting JSON, our skills we pride.
Hopping along, we code with glee,
A brighter future, for you and me! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.