refactor(mock): switch mocking library from golang/mock to go.uber.org/mock

elprogramadorgt commented 3 weeks ago

switch mocking library from golang/mock to go.uber.org/mock

Summary by CodeRabbit

Chores
- Updated the mocking framework from github.com/golang/mock/gomock to go.uber.org/mock/gomock across multiple files, ensuring improved compatibility and maintenance.
- Modified import statements in various test files to reflect the new mocking library without changing the overall test logic or structure.

coderabbitai[bot] commented 3 weeks ago

[!NOTE]

Reviews paused

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.

@coderabbitai review to trigger a single review.

Walkthrough

The pull request introduces changes primarily focused on updating the mocking library used throughout the codebase from github.com/golang/mock to go.uber.org/mock. This transition affects various test files and the Makefile, which now installs the mockgen tool from the new source. Additionally, updates to the go.mod file reflect changes in dependency versions and the addition of new dependencies, ensuring compatibility and maintenance of the project.

Changes

File Path	Change Summary
Makefile	Updated installation command for `mockgen` from `github.com/golang/mock/mockgen@v1.6.0` to `go.uber.org/mock/mockgen@v0.5.0`.
go.mod	- Added dependency: `github.com/golang/mock v1.6.0` - Removed dependency: `github.com/golang/mock v1.6.0` - Updated: `golang.org/x/mod v0.17.0` to `v0.18.0` - Updated: `golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d` to `v0.22.0`
x/logic/fs/composite/fs_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/fs/filtered/fs_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/fs/wasm/fs_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/keeper/features_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/keeper/grpc_query_ask_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/keeper/grpc_query_params_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/keeper/migrations_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/keeper/msg_server_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/meter/weighted_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/predicate/bank_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/predicate/builtin_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/predicate/util_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/expected_keepers_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/fs_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/gas_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/interface_registry_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/keeper_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/logic/testutil/read_file_fs_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/mint/keeper/genesis_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/mint/keeper/grpc_query_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/mint/keeper/keeper_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/mint/testutil/expected_keepers_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/vesting/msg_server_test.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.
x/vesting/testutil/expected_keepers_mocks.go	Updated import path for `gomock` from `github.com/golang/mock/gomock` to `go.uber.org/mock/gomock`.

Possibly related issues

axone-protocol/axoned#770: This issue suggests switching the mocking library from golang/mock to go.uber.org/mock, which aligns with the changes made in this PR.

Possibly related PRs

#776: This PR updates the Makefile to install the mockgen tool from a different source, directly related to the changes made in this PR.
#779: This PR updates the Go version and modifies the Makefile, which may indirectly relate to the changes in dependency management and tool installations in the main PR.

Suggested reviewers

bdeneux
ccamel
amimart

🐰 In the meadow, we hop and play,
With mocks updated, hip-hip-hooray!
From golang to uber, we leap so high,
Testing our code, reaching for the sky!
With every change, our project will thrive,
Hopping along, keeping the code alive! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

ccamel commented 3 weeks ago

@coderabbitai resolve

coderabbitai[bot] commented 3 weeks ago

:white_check_mark: Actions performed

Comments resolved.

ccamel commented 3 weeks ago

@coderabbitai pause

coderabbitai[bot] commented 3 weeks ago

:white_check_mark: Actions performed

Reviews paused.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   42.73%   42.73%           
=======================================
  Files         111      111           
  Lines        6273     6273           
=======================================
  Hits         2681     2681           
  Misses       3468     3468           
  Partials      124      124

Files with missing lines	Coverage Δ
x/logic/testutil/expected_keepers_mocks.go	`90.24% <ø> (ø)`
x/logic/testutil/fs_mocks.go	`100.00% <ø> (ø)`
x/logic/testutil/gas_mocks.go	`81.08% <ø> (ø)`
x/logic/testutil/interface_registry_mocks.go	`10.37% <ø> (ø)`
x/logic/testutil/keeper_mocks.go	`84.31% <ø> (ø)`
x/logic/testutil/read_file_fs_mocks.go	`100.00% <ø> (ø)`
x/mint/testutil/expected_keepers_mocks.go	`75.55% <ø> (ø)`
x/vesting/testutil/expected_keepers_mocks.go	`100.00% <ø> (ø)`

axone-protocol / axoned