Feat/expose database predicates

ccamel commented 2 weeks ago

Expose the ISO predicates related to “database” management, specifically those used for handling dynamic predicates.

Summary by CodeRabbit

New Features
- Introduced features for asserta/1, assertz/1, and retract/1 predicates in Prolog, with multiple scenarios demonstrating their functionality.
- Scenarios include asserting facts, handling dynamic vs. static predicates, and managing an inventory system.
Bug Fixes
- Improved error handling for attempts to assert or retract static predicates.
Documentation
- Comprehensive test cases and expected outputs for new features to enhance user understanding.

coderabbitai[bot] commented 2 weeks ago

Walkthrough

This pull request introduces three new feature files for testing Prolog predicates: asserta/1, assertz/1, and retract/1. Each feature file contains multiple scenarios that demonstrate the functionality of these predicates in managing facts within a Prolog database. Additionally, a new Go package named predicate is added, which implements the corresponding functions for asserting and retracting facts in the database.

Changes

File	Change Summary
`x/logic/keeper/features/asserta_1.feature`	- New feature: `asserta/1` - Scenarios added: Assert a fact, Only dynamic predicates can be asserted, Show that the fact is asserted at the beginning, Shows a simple counter example.
`x/logic/keeper/features/assertz_1.feature`	- New feature: `assertz/1` - Scenarios added: Assert a fact, Only dynamic predicates can be asserted, Show that the fact is asserted at the end, Add and remove items in an inventory.
`x/logic/keeper/features/retract_1.feature`	- New feature: `retract/1` - Scenarios added: Retract a fact from the database, Only dynamic predicates can be retracted.
`x/logic/predicate/database.go`	- New methods added: `Asserta`, `Assertz`, `Retract`, `Abolish` for managing clauses in the database.

Possibly related PRs

#783: The changes in this PR involve the assertz/1 predicate, which is closely related to the asserta/1 predicate tested in the main PR, as both deal with asserting facts into a Prolog database and include scenarios that emphasize the differences in their behavior.

Suggested reviewers

bdeneux
amimart

Poem

🐰 In the realm of facts, we hop and play,
With asserta and assertz, we pave the way.
Retracting truths, oh what a sight,
Dynamic predicates dance in the light!
So let’s celebrate with a joyful cheer,
For Prolog’s magic brings us near! ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
x/logic/predicate/database.go	0.00%	8 Missing :warning:

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   42.73%   42.68%   -0.06%     
==========================================
  Files         111      112       +1     
  Lines        6273     6281       +8     
==========================================
  Hits         2681     2681              
- Misses       3468     3476       +8     
  Partials      124      124

Files with missing lines	Coverage Δ
x/logic/predicate/database.go	`0.00% <0.00%> (ø)`

ccamel commented 2 weeks ago

@coderabbitai please approve PR. thx

coderabbitai[bot] commented 2 weeks ago

@ccamel: I've approved the PR. Thank you.

:white_check_mark: Actions performed

Comments resolved.

axone-protocol / axoned