[Law-stone] Remove instantiate context state and use reply payload

bdeneux commented 3 months ago

On the law-stone contract, replace current instantiation context state by the new payload on Reply sub message introduced in cosmwasm v2.0.0, following @amimart suggestion

Summary by CodeRabbit

New Features
- Enhanced clarity and efficiency in the smart contract's instantiation and reply message handling.
Bug Fixes
- Improved error handling for string conversion in reply messages.
Tests
- Updated tests to ensure correct payload handling and validate error management for invalid data.

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes streamline the smart contract's handling of instantiation and reply processes in Rust. The removal of the INSTANTIATE_CONTEXT constant simplifies state management, while direct payload conversion enhances clarity and error handling. Tests have been updated accordingly, ensuring robustness and correctness in the new logic. Overall, these modifications improve the efficiency, clarity, and reliability of the contract's operations.

Changes

Files	Change Summary
`contracts/axone-law-stone/src/contract.rs`	Simplified instantiation by removing `INSTANTIATE_CONTEXT`, enhancing response creation and error handling in the reply logic. Tests updated to reflect changes.
`contracts/axone-law-stone/src/state.rs`	Removed declaration of constant `INSTANTIATE_CONTEXT`, indicating a refactor in instantiation context management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Contract
    participant Storage

    User->>Contract: Instantiate Contract
    Contract->>Storage: Store Address
    Contract-->>User: Send Submessage
    User->>Contract: Reply with Payload
    Contract->>Storage: Process Payload
    Contract-->>User: Response

🐰 In the garden of code so bright,
A change has brought a new delight.
With clearer paths and errors tamed,
Our smart contract now is famed!
Hops of joy, we celebrate,
A cleaner code, oh, isn’t it great? 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

bot-anik commented 3 months ago

size-limit report 📦

Path	Size
target/wasm32-unknown-unknown/release/axone_objectarium.wasm	458.07 KB (0%)
target/wasm32-unknown-unknown/release/axone_law_stone.wasm	647.92 KB (-0.24% 🔽)
target/wasm32-unknown-unknown/release/axone_cognitarium.wasm	831.35 KB (0%)
target/wasm32-unknown-unknown/release/axone_dataverse.wasm	670.43 KB (0%)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files	Coverage Δ
contracts/axone-law-stone/src/contract.rs	`96.09% <100.00%> (+0.10%)`	:arrow_up:
contracts/axone-law-stone/src/state.rs	`100.00% <ø> (ø)`

axone-protocol / contracts