search

axonivy-market / docuware-connector

DocuWare is a document management system
Apache License 2.0
0 stars 1 forks source link

bugfix/RHT-4505-Upload-to-docuware-not-possible-after-release-4.0.0 #55

Closed ntqdinh-axonivy closed 3 months ago

ntqdinh-axonivy commented 3 months ago

Hi @ivy-rew after the previous PR to get the error message from Docuware https://github.com/axonivy-market/docuware-connector/pull/49/files, we detect that the logon request required 1 more param of "organization" image

But in our dev account, the param of "organization" in logon request is not required so I let it as an optional param. I would happy if you have a quick look on it before we release a new version with this attr. Thanks.

github-actions[bot] commented 3 months ago

Test Results

18 tests  ±0   18 :white_check_mark: ±0   23s :stopwatch: -3s  6 suites ±0    0 :zzz: ±0   6 files   ±0    0 :x: ±0 

Results for commit f6aaa4bc. ± Comparison against base commit d56212c2.

:recycle: This comment has been updated with latest results.

ivy-rew commented 3 months ago

I think we have tests around this auth-feature; I'd quickly add a new test-method ... verifying that the property is in charge if set: https://github.com/axonivy-market/docuware-connector/blob/master/docuware-connector-test/src_test/com/axonivy/market/docuware/connector/TestDocuWareAuthFeature.java#L23C14-L23C37