axonivy-market / market

Axon Ivy Market
https://market.axonivy.com
Apache License 2.0
2 stars 11 forks source link

Onboard Google Translate Connector to Axon-ivy market #291

Closed TuDoanQuang46 closed 1 year ago

TuDoanQuang46 commented 1 year ago

Hi, I've just created a market-product that I'd like to publish into the official axonivy-market. Can you fork it and review my cool product? https://github.com/TuDoanQuang46/google-translate-connector


⚠️ do not remove this section, but leave it to track the reviewer's work.

Review Tasks

Product Domain

Technical Solution

Coherent

Maintainable

ivy-rew commented 1 year ago

started the technical review https://github.com/axonivy-market/google-translate-connector/pull/1

ivy-rew commented 1 year ago

technical review is done: the connector is good to go from a technical standpoint. thanks a lot for the contribution @TuDoanQuang46 . Can you shortly share whether there is a team involved in keeping the product stable in the future? or is there an active project which will have the lead on this connector? or who should be invited to the new repo on the axonivy-market?

can you give a short feedback on this new connector @andreasbalsiger ? would like to have this connector officially listed on market.axonivy.com? Is the currenct product description ok to be re-used as template for the official market listing? https://github.com/axonivy-market/google-translate-connector/blob/master/google-translate-connector-product/README.md

ivy-jhi commented 1 year ago

Hi @ivy-rew, @TuDoanQuang46 is member of team Bolt. So either team Bolt will take care or maybe our presales colleagues. So please invite team Bolt and Presales.

Thx!

ivy-rew commented 1 year ago

Hi @ivy-rew, @TuDoanQuang46 is member of team Bolt. So either team Bolt will take care or maybe our presales colleagues. So please invite team Bolt and Presales.

Thx!

Thanks a lot Johannes for clarifying the responsibilities. Within the axonivy-market org the team-bolt is not formally defined. We can create one, but I assume that there won't be frequent maintenance required for this product, so it might be an overhead to re-define that team in advance.

So I added you as "maintainer", in order that you can invite further contributors on this repo. And @TuDoanQuang46 as 'writable' developer... so you guys are able to maintain the repo on your own. .... of course you can still involve me on pull-requests for reviews if you like, but there is no formal requirement to do so.

ivy-rew commented 1 year ago

one more thing @TuDoanQuang46 , it would help if you delete your personal repository https://github.com/TuDoanQuang46/google-translate-connector in order to make PRs simpler. Otherwise PRs are by default suggested to be merged back into your origin repo. As you now have write access in the axonivy-market repo, you could directly work on this one. still any third-party can create private forks from the new market repo and contribute back to it.

andreasbalsiger commented 1 year ago

Hey @ivy-rew : this would be my additional bullet points in the readme:

ivy-rew commented 1 year ago

thanks for your feedback @andreasbalsiger , just added your points to the readme: https://github.com/axonivy-market/google-translate-connector/pull/4/files

next and final step I'll take:

ivy-rew commented 1 year ago

The connector is live in a first version: https://market.axonivy.com/google-translate#tab-description Thanks for all your work @TuDoanQuang46 , @ivy-jhi & @andreasbalsiger