search

axonivy-market / market

Axon Ivy Market
https://market.axonivy.com
Apache License 2.0
2 stars 11 forks source link

Fix build. Rename icon.png to logo.png. Fix meta.json to match schema #336

Closed weissreto closed 11 months ago

weissreto commented 11 months ago

Hi @linhpd-axonivy

We have an internal build that checks if there is a logo available and if the meta.json fulfills the schema definition. This build was broken by my previous PR. I didn't see that it was broken. Sorry for that.

For you as a reviewer and maintainer of this repository, it is a must that you check the build before you accept a PR. Unfortunately, you do not have access to the build. Therefore, you should migrate the build from Jenkins (Jenkinsfile) to GitHub Actions. This should be an easy task since GitHub Actions has templates to run maven builds. It will help you in the future to keep the repository healthy.

I was a bit surprised that you merged my PR. Normally we do not work this way in our team. The reviewer only accepts the PRs and the author can then clean up the history and merge the PR.

However, I think both ways are possible but it should be documented how it is done in this repository in the README.

Thanks

weissreto commented 11 months ago

Build is green now for the PR. I will merge so that the build on master gets green again.

ghost commented 11 months ago

Hi @weissreto , I wanted to extend my sincere apologies for the oversight in my recent PR that led to the internal build being broken. I genuinely didn't catch the issue, and I understand the inconvenience it has caused.