search

axonivy-market / market

Axon Ivy Market
https://market.axonivy.com
Apache License 2.0
2 stars 11 forks source link

MARP-302: Update meta.json - Add 2 more artifacts #379

Closed ndkhanh-axonivy closed 2 months ago

github-actions[bot] commented 2 months ago

Test Results

12 tests  ±0   12 :white_check_mark: ±0   26s :stopwatch: -12s  3 suites ±0    0 :zzz: ±0   3 files   ±0    0 :x: ±0 

Results for commit e03a4e3d. ± Comparison against base commit 6b749cf8.

:recycle: This comment has been updated with latest results.

ndkhanh-axonivy commented 2 months ago

Hi @ivy-rew , I would like to add the iar file as one of the Portal artifact in the meta.json. So then I add iar as enum of the ArtifactType, is it correct? Please check it and give me your feedbacks, thanks!

ivy-rew commented 2 months ago

I don't think that fixes any problems. We do not have to list IAR artifacts in order to make them appear on the market. We didn't do this in any other product. Look at the "installMatcher": "best-match", which only exists for Portal. I assume it makes the special versioning selection. Also it list different IAR files for different versions. If you use 10 you'll see AxonIvyExpress for instance. I assume you have to solve this problem on the market-website, not here.

ndkhanh-axonivy commented 2 months ago

Thanks for your feedback @ivy-rew , I'll close it.