Review Tasks

Product Domain

[x] product successfully installs into the Axon Ivy Designer
[x] product parts are marked as Connector or Demo
[x] the product projects contains documentation to explain the functionality or use-case: e.g. Process-Notes, Input-Parameter descriptions, Meta-Comments on variables.yaml definitions ...

[x] Common group-id for all artifacts <groupId>[org.arcme|com.axonivy].[util|connector].[product-name]<groupId>
[x] Common artifact-id prefix: <artifactId>msgraph[-product|test|demo]</artifactId>
[x] Html-Dalogs depend on suggested 'frame' template
[x] Github actions + maven-build runs as outlined in market-product template

[x] Dependent third-party infrastructure (e.g. Database, MavenRepos) is available: public accessible instance or shared as code (e.g. Docker, docker-compose)
[x] Tests are implemented that verify, that the product actually runs
[x] Additional libraries (e.g. Maven dependencies) are lightweight: not duplicating libaries of the Axon.ivy Classpath Container.
[x] Depends on standard Axon Ivy features and does not light-heartedly re-introduce forks of existing solutions (e.g. Job-Framework). Our goal is to integrate also third-parties into existing: Enginge-Cockpit-View, Log-Channels, Monitoring features, ...
[x] Uses latest ivy-environment: e.g. process-files and used project-build-plugin match the ivyProject version.
[x] Product is re-usable without the need to unpack and customize it for standard use-cases: crucial settings can be overriden with well documented config/variables.yaml

[x] the product readme fits into the market landscape (Andreas Balsinger)
[x] all mandatory setup steps to run the Demo are documented in the setup section of the [myProduct]/product/Readme.md .

andreasbalsiger commented 5 months ago

Do I already need to be assigned? Or does this happen throughout the "recipe" that appears when you start with a new connector project? @ivy-sgi ?

ivy-sgi commented 5 months ago

I have unassigned you @andreasbalsiger - we will come back to you soon to approve the documentation.

ivy-rew commented 5 months ago

Do I already need to be assigned? Or does this happen throughout the "recipe" that appears when you start with a new connector project? @ivy-sgi ?

hi @andreasbalsiger you will be notified again on each and every new connector on-boarding. If you don't like that, Octopus can remove you from the list of automatically assigned users: https://github.com/axonivy-market/market/blob/master/.github/ISSUE_TEMPLATE/onboard-to-market.md?plain=1#L9 onboard-template

phhung-axonivy commented 5 months ago

This connector is live in the first version: https://market.axonivy.com/mattermost-connector so I will close this issue. Thanks for your valuable feedback @andreasbalsiger @ivy-sgi