Closed ntqdinh-axonivy closed 2 months ago
12 tests ±0 12 :white_check_mark: ±0 25s :stopwatch: -5s 3 suites ±0 0 :zzz: ±0 3 files ±0 0 :x: ±0
Results for commit d4bfc9bf. ± Comparison against base commit 6dce5caa.
:recycle: This comment has been updated with latest results.
Hi @ivy-rew I have a short discussion with Alex abt the new schema to cover all artifacts with old group id & artifact id in this PR https://github.com/axonivy-market/market.axonivy.com/pull/36. However, I was not aware that a new version of the schema should be introduced. I'm so sorry for that thing.
I have just updated the schema based on your suggestion in this PR https://github.com/axonivy-market/market/pull/374 How can we publish it with the version of 10.0.1? Is new directory created in this page https://json-schema.axonivy.com/market/ after Jenskin is triggerred?
Hi @ivy-rew I have a short discussion with Alex abt the new schema to cover all artifacts with old group id & artifact id in this PR axonivy-market/market.axonivy.com#36. However, I was not aware that a new version of the schema should be introduced. I'm so sorry for that thing.
I have just updated the schema based on your suggestion in this PR #374 How can we publish it with the version of 10.0.1? Is new directory created in this page https://json-schema.axonivy.com/market/ after Jenskin is triggerred?
Thanks @ntqdinh-axonivy for addressing the missed schema updated. In the future we will get this tackled by sticking to the 'review-with-the-repo-owners' rule :wink:
And yes, the auto-triggered build will publish the meta.json. To introduce the new version you'll have to raise is in the pom.xml of https://github.com/axonivy-market/market/blob/master/market-test/pom.xml#L127 > 10.0.1
let's prevent missing schema updates in the future, I've introduced a check ... so this does not happen again unnoticed https://github.com/axonivy-market/market/pull/384
After merging this, we still will temporarily see builds failing ... since 'archivedArtifacts' were already in use without an according schema published. ... to fix it you simply need to use the latest '10.0.1' version in products that use the new term. https://github.com/axonivy-market/market/pull/384
Hi @ivy-rew I have just updated the description and example for archived artifacts. Could you please have a final look at it before we publish new version of schema :)
update market meta schema