Open lndanh-axonivy opened 2 weeks ago
@lndanh-axonivy
Hi @phochstr , Alex made some updates. Could you help us to review it again? Thank you!
Hi @phochstr , Is this PR OK to merge?
No. It is in the exact same state as I reviewed it first time. Has there been a Commit by Alex?
I try to get @AlexSchaIvy to tell me what he intended to change as I see no single change here.
[like] Peter Hochstrasser reacted to your message:
From: Le Ngoc Danh @.> Sent: Tuesday, October 22, 2024 4:21:48 AM To: axonivy-market/portal @.> Cc: Peter Hochstrasser @.>; Mention @.> Subject: Re: [axonivy-market/portal] IVYPORTAL-17731 Create accessibility documentation: update document (PR #1120)
Hi @phochstrhttps://github.com/phochstr , Is this PR OK to merge?
— Reply to this email directly, view it on GitHubhttps://github.com/axonivy-market/portal/pull/1120#issuecomment-2428199341, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAVIIPYETTFANJ3IE54DF6DZ4XHFZAVCNFSM6AAAAABPUGHKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGE4TSMZUGE. You are receiving this because you were mentioned.Message ID: @.***>
Hi @phochstr , I pushed some changes following your feedback. Please help us review it again. Thank you
I changed everything and incorporated Peters requested changes and commited the changes to the branch