search

axonivy-market / portal

Axon Ivy Portal
https://market.axonivy.com/portal
Apache License 2.0
10 stars 3 forks source link

IVYPORTAL-17731 Create accessibility documentation: update document #1120

Open lndanh-axonivy opened 2 weeks ago

AlexSchaIvy commented 1 week ago

I changed everything and incorporated Peters requested changes and commited the changes to the branch

AlexSchaIvy commented 1 week ago

@lndanh-axonivy

lndanh-axonivy commented 1 week ago

Hi @phochstr , Alex made some updates. Could you help us to review it again? Thank you!

lndanh-axonivy commented 5 days ago

Hi @phochstr , Is this PR OK to merge?

phochstr commented 5 days ago

No. It is in the exact same state as I reviewed it first time. Has there been a Commit by Alex?

phochstr commented 5 days ago

I try to get @AlexSchaIvy to tell me what he intended to change as I see no single change here.

phochstr commented 4 days ago

[like] Peter Hochstrasser reacted to your message:

From: Le Ngoc Danh @.> Sent: Tuesday, October 22, 2024 4:21:48 AM To: axonivy-market/portal @.> Cc: Peter Hochstrasser @.>; Mention @.> Subject: Re: [axonivy-market/portal] IVYPORTAL-17731 Create accessibility documentation: update document (PR #1120)

Hi @phochstrhttps://github.com/phochstr , Is this PR OK to merge?

— Reply to this email directly, view it on GitHubhttps://github.com/axonivy-market/portal/pull/1120#issuecomment-2428199341, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAVIIPYETTFANJ3IE54DF6DZ4XHFZAVCNFSM6AAAAABPUGHKNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRYGE4TSMZUGE. You are receiving this because you were mentioned.Message ID: @.***>

lndanh-axonivy commented 1 day ago

Hi @phochstr , I pushed some changes following your feedback. Please help us review it again. Thank you