axonivy / log-viewer

A small and simple Axon Ivy Engine log viewer
5 stars 1 forks source link

XIVY-3061 #11

Closed zenosaurusflex closed 5 years ago

zenosaurusflex commented 5 years ago

https://jira.axonivy.com/jira/browse/XIVY-3061

ivy-dhu commented 5 years ago
zenosaurusflex commented 5 years ago
  • When applying the timespan filter and then changing the level it doesn't apply the timespan filter. Either reset the filter in that case or apply in on the run.

@ivy-dhu I dont think reseting the filter in that case would make any sense due to ux-concerns. I'll apply the filter there aswell, forgot about that, thanks! :^)

zenosaurusflex commented 5 years ago

I can't see the icon-image in this commit as well as in my checked out ws

You can see it was committed here: https://github.com/zenosaurusflex/ivy-log-viewer/commit/ff44ec145920683ed1e890e2504f761eca705dcd (plus_16.png)

Available in the repository aswell: https://github.com/zenosaurusflex/ivy-log-viewer/blob/ff44ec145920683ed1e890e2504f761eca705dcd/src/main/resources/images/plus_16.png

Also in the changed files of the PR - should be a problem on your side https://github.com/ivy-supplements/ivy-log-viewer/pull/11/files

ivy-dhu commented 5 years ago

Right the image is inside and it just didn't update on my side. Sorry my bad. But I just downloaded the zip and opened the log-viewer on a win10 vm and I still don't see any icon on the button... It tried it on several other vms and it never appears to me. image

image

zenosaurusflex commented 5 years ago

Right the image is inside and it just didn't update on my side. Sorry my bad. But I just downloaded the zip and opened the log-viewer on a win10 vm and I still don't see any icon on the button... It tried it on several other vms and it never appears to me. image

image

woops closed by mistake - can you try pulling and then building again? Pretty sure it was the icon-url. mb

ivy-dhu commented 5 years ago

Now the icon appears.

ivy-dhu commented 5 years ago

If you don't have anything you might wanna change before I merge it's fine to me.