search

axonops / axonops-workbench-cassandra

AxonOps™ Workbench for Apache Cassandra®
https://axonops.com
Apache License 2.0
1 stars 0 forks source link

Incorrect logs directory #22

Closed digiserg closed 2 weeks ago

digiserg commented 1 month ago

The logs directory is set as

this.loggingFilesPath = Path.join((extraResourcesPath != null ? Path.join(extraResourcesPath) : Path.join(__dirname, '..', '..')), 'data', 'logging')

This is not correct. I should point to app.getPath('logs') as this is not working at least for Mac. I haven't tested others yet.

The correct paths are:

on Linux: ~/. config/{app name}/logs/main.log. on macOS: ~/Library/Logs/{app name}/main.log. on Windows: %USERPROFILE%\AppData\Roaming{app name}\logs\main.log.

mhmdkrmabd commented 3 weeks ago

Changes have been made, tested on Linux, will be tested on macOS.

mhmdkrmabd commented 3 weeks ago

Tested on macOS

Image

digiserg commented 3 weeks ago

Great, thanks. Please merge to main if you haven't already and will test it

mhmdkrmabd commented 3 weeks ago

@digiserg sure will just finish the remaining two issues, will commit everything with tagging the related issues to do further tests

digiserg commented 3 weeks ago

Tested on Mac where it looks good

millerjp commented 3 weeks ago

@digiserg @mhmdkrmabd can we close this now?