search

axonops / axonops-workbench

AxonOps™ Workbench for Apache Cassandra® - Desktop application for Mac, Windows and Linux
https://axonops.com
Apache License 2.0
11 stars 0 forks source link

Review the new GitHub attestations #108

Open digiserg opened 4 months ago

digiserg commented 4 months ago

https://github.blog/2024-05-02-introducing-artifact-attestations-now-in-public-beta/

digiserg commented 1 month ago

image

digiserg commented 1 month ago

The attestations appear to work the Windows builds and I have disabled them again.

https://github.com/electron-userland/electron-builder/issues/7248

millerjp commented 1 month ago

@digiserg whats the status of this - I am confused as to if this is done for 1.0?

digiserg commented 1 month ago

One of the requirements for the attestations to work is to change the pipeline permissions using:

permissions:
  id-token: write
  attestations: write

but this seems to be affecting electron-builder and it can't sign the builds. We'll leave this to the next release when I have more time to investigate it.