axonops / axonops-workbench

AxonOps™ Workbench for Apache Cassandra® - Desktop application for Mac, Windows and Linux
https://axonops.com
Apache License 2.0
11 stars 0 forks source link

[feat] About screen does not tell you about the application #243

Closed rgooding closed 2 months ago

rgooding commented 3 months ago

The About dialog in an application is supposed to be just that - it tells you about the application, we seem to have missed that part when designing ours! The first thing I would expect to see when opening the About dialog is something showing the name of the application, the company who produced it, the copyright year and most importantly the version number.

Screenshot 2024-08-12 at 16 27 41 Screenshot 2024-08-12 at 16 27 35
millerjp commented 3 months ago

@rgooding this is done here. I think what we can put in here is limited.

Screenshot 2024-08-12 at 16 26 22 Screenshot 2024-08-12 at 16 30 38

@mhmdkrmabd do you have any ideas on how we could line these both up. Could we use About in the menu bar to launch our about dialog?

eg (or something like that)

const { Menu } = require('electron');

const menuTemplate = [
  {
    label: 'Help',
    submenu: [
      {
        label: 'About',
        click: () => createAboutWindow()
      }
    ]
  }
];

const menu = Menu.buildFromTemplate(menuTemplate);
Menu.setApplicationMenu(menu);

See #83

mhmdkrmabd commented 3 months ago

@millerjp

Image