axonops / axonops-workbench

AxonOps™ Workbench for Apache Cassandra® - Desktop application for Mac, Windows and Linux
https://axonops.com
Apache License 2.0
10 stars 0 forks source link

[feat]: Change build to use an env variable to set version rather than hardcoded as version in package.json #351

Closed millerjp closed 1 week ago

millerjp commented 4 weeks ago

Is your feature request related to a problem? Please describe. Yes - we have to update package.json on branches/builds for versions and its not ideal as this is an important file to keep updated and it makes merges difficult etc.. as package.json can be updated anyway

Describe the solution you'd like Remove version from package.json and inject version into the build. electron-builder can load this from a .env file and inject into the build.

Additional context Heres an example on how to do this https://www.perplexity.ai/search/respond-to-each-query-using-th-WzqoUccQShGuTqdhIhjiog

digiserg commented 4 weeks ago

There is a good way of doing this with the following github action but the current tagging/versioning model we use does not work well. We'd need to rethink it.

https://github.com/phips28/gh-action-bump-version

digiserg commented 1 week ago

It's done as part of the github pipeline now