The `call` method in executor should handle system contracts as `exec` method does. - Githubissues

axonweb3 / axon

Axon is a Layer 2 framework of CKB with native cross-chain and interoperability.

https://axonweb3.io

MIT License

65 stars 39 forks source link

The `call` method in executor should handle system contracts as `exec` method does. #1592

Closed yangby-cryptape closed 9 months ago

yangby-cryptape commented 9 months ago

Description

Current status

The exec method in executor do special operations for system contracts.

https://github.com/axonweb3/axon/blob/264a67673334cdbf7e1021e5af71f21c95553fea/core/executor/src/lib.rs#L152-L153
But call method doesn't.

https://github.com/axonweb3/axon/blob/264a67673334cdbf7e1021e5af71f21c95553fea/core/executor/src/lib.rs#L65

Issues introduced by the above Design

When call system contracts —— for example, call eth_estimateGas —— it may lead to unexpected results.

Also, unexpected results may be occurred when replay system contracts (ref: #1234 tried).

Proposals

Do same operations for both exec and call.
Or, just reject system contracts directly in the call method.

Flouse commented 9 months ago

confirmed solution

just reject system contracts directly in the call method

yangby-cryptape commented 9 months ago

I found that #1597 will resolve this issue.

p.s. This comment is created via GitHub CLI.