Closed KaoImin closed 7 months ago
yangby-cryptape
commented
7 months ago Not for your PR, your PR is fine, just ask for future plans.
yangby-cryptape
commented
7 months ago
- Should it contain the peer-id calculation?
Do you mean this peer-id?
I reviewed the CLI arguments, if I have a network private key, there is no command to display its info. Same for BLS key, but network key is more likely to be used, because you have to tell people who want to connect you every time.
If you have more than 1 keys, it's possible you could mix them up.
KaoImin
commented
7 months ago Questions
Not for your PR, your PR is fine, just ask for future plans.
- Not in CI (or no tests in CI), how to guarantee availability after another PR?
Is it contained in releases?
- Why not be a subcommond of Axon? So users don't have to use two binaries?
- Should it contain the peer-id calculation? Today, when I generate a new network key, I have to use CKB to display the peer-id.
I am integrating the keypair generator into Axon binary.
Flouse
What this PR does / why we need it?
This PR update the axon keypair generator.
What is the impact of this PR?
No Breaking Change
PR relation:
CI Settings
### **CI Usage** **Tip**: Check the CI you want to run below, and then comment `/run-ci`. **CI Switch** - [ ] Web3 Compatible Tests - [ ] OpenZeppelin tests - [ ] v3 Core Tests ### **CI Description** | CI Name | Description | | ---------------------- | ------------------------------------------------------------------------------------------------------- | | *Web3 Compatible Test* | Test the Web3 compatibility of Axon | | *v3 Core Test* | Run the compatibility tests provided by Uniswap V3 | | *OpenZeppelin tests* | Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19 |