search

axonweb3 / axon

Axon is a Layer 2 framework of CKB with native cross-chain and interoperability.
https://axonweb3.io
MIT License
65 stars 39 forks source link

refactor!: increase max gas limitation #1630

Closed KaoImin closed 7 months ago

KaoImin commented 7 months ago

What this PR does / why we need it?

This PR increase max gas limitation to 50 million.

What is the impact of this PR?

PR relation:

CI Settings
### **CI Usage** **Tip**: Check the CI you want to run below, and then comment `/run-ci`. **CI Switch** - [ ] Web3 Compatible Tests - [ ] OpenZeppelin tests - [ ] v3 Core Tests ### **CI Description** | CI Name | Description | | ---------------------- | ------------------------------------------------------------------------------------------------------- | | *Web3 Compatible Test* | Test the Web3 compatibility of Axon | | *v3 Core Test* | Run the compatibility tests provided by Uniswap V3 | | *OpenZeppelin tests* | Run the compatibility tests provided by OpenZeppelin, including OCT 1-5 \| 6-10 \| 11 \| 12-15 \| 16-19 |
Flouse commented 7 months ago

  1. https://github.com/godwokenrises/godwoken-tests/pull/319 This PR has fixed the test in a simple way. I think it's should be discussed if this PR could be merged, because it might be a breaking change.

  2. The root cause may not be the max gas limitation @KaoImin

    Why did eth_estimateGas cost all gas in that test case?