search

axperty / cratedelight

A Minecraft mod that adds more crates and bags to the game, that are useful to save storage.
https://curseforge.com/minecraft/mc-mods/crate-delight-forge
Other
2 stars 3 forks source link

Crate Delight tries to load recipes with ingredients that don't exist #3

Closed Sirfirelord1 closed 6 months ago

Sirfirelord1 commented 6 months ago

When mods such as Create are not in the pack, it tries to load those recipes for create compat anyway, causing an error (non-crash) Minor error but it seems to be missing a check for what other mods are in the pack

axperty commented 6 months ago

Hi Sirfirelord1,

I'll make it load the recipe if the mod is loaded, seems like I forgot to add that. If you have any other errors, please let me know. A minor update will be released to fix this.

Have a good day, Axperty.

Sirfirelord1 commented 6 months ago

Thanks for the fast response. Did some more looking through error logs and it appears that the same thing happens for More Delight (Forge) and possibly Storage Delight (not sure) - but i couldn't find a github for either of those linked, so I'm just following up here. Thanks for the great mods, by the way, we're using all 3 in our modpack <3

axperty commented 6 months ago

I think it might happen in More Delight, but I'm not really sure, because I recently added recipe conditions there. I'm also working on having all mod versions on GitHub so it's easier to see the source code.

Thank you for using my mods, it means a lot, and I really appreciate it!

Sirfirelord1 commented 6 months ago

Next time i see the error in console, i'll copy-paste it here if that helps!

axperty commented 6 months ago

Hi Sirfirelord1,

I recently submitted an update for Crate Delight addressing this issue, it should be fixed for now. The only thing is that I noticed it's not working on 1.20, but if you're playing 1.20.1 or 1.20.2, you won't have any issues.

Have a good day, Axperty.

pajicadvance commented 2 months ago

This is still happening in the latest version for Fabric 1.21 (24.08.09). I don't think it's fixed.

https://mclo.gs/McF1MNY