ay-lab / FitHiChIP

Statistically Significant loops from HiChIP data
MIT License
39 stars 20 forks source link

Hicpro version #68

Closed xumai-du closed 2 years ago

xumai-du commented 2 years ago

For the latest version of FitHiChIP(9.1.0), is it still mandatory to use Hicpro/2.11.4? Thanks!

ay-lab commented 2 years ago

Hi @xumai-du Thanks for your query. HiC-pro version should be >= 2.11.4. We recommend using the latest version of HiCPro.

xumai-du commented 2 years ago

Thank you for the quick reply!

SO I used Hicpro/3.1.0 but it didn’t work. The problem seems to be related with ICE procedure. Please see attached out file. Note: we use FitHiChIP/9.1 although it was labelled as 9.1_2. It was only labelled differently so that we can test different versions of hicpro.

Mai

From: ay-lab @.> Sent: Wednesday, December 29, 2021 9:27 PM To: ay-lab/FitHiChIP @.> Cc: Xu, Mai (NIH/NCI) [E] @.>; Mention @.> Subject: [EXTERNAL] Re: [ay-lab/FitHiChIP] Hicpro version (Issue #68)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and are confident the content is safe.

Hi @xumai-duhttps://github.com/xumai-du Thanks for your query. HiC-pro version should be >= 2.11.4. We recommend using the latest version of HiCPro.

— Reply to this email directly, view it on GitHubhttps://github.com/ay-lab/FitHiChIP/issues/68#issuecomment-1002845802, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APU7EOH6ORQXHOATDQZT5NTUTO7PHANCNFSM5K64WUAA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

ay-lab commented 2 years ago

Hi @xumai-du Does the problem persist? In general, HiCPro version 3.1.0 should work. Need to install the ICE as suggested in the HiC-pro documentation. FitHiChIP searches the ICE executable before bias correction.