ay-lab / dcHiC

dcHiC: Differential compartment analysis for Hi-C datasets
MIT License
57 stars 10 forks source link

functionsdchic.cpp:12:10: fatal error: BMAcc.h: No such file or directory #25

Closed papelypluma closed 2 years ago

papelypluma commented 2 years ago

Hi dcHiC developers, I'd like to ask for help on installing functionsdchic_1.0.tar.gz. I've followed the instructions via Conda, and the following compilation error is encountered. Is there a way to address this issue?

functionsdchic.cpp:12:10: fatal error: BMAcc.h: No such file or directory 12 | #include

Thank you!

ay-lab commented 2 years ago

Hi! Thank you for using our tool. That is an interesting error—I don't think I have seen it before. What commands have you run for the download? Via conda it should only be a few: git clone, conda env create, conda activate, and then R CMD INSTALL dchicfunctions.

The-Hungry-Caterpillar commented 2 years ago

Hi,

I really appreciate this awesome tool you're providing!

Alas, I also got this error, and so did my colleague.

I did:

git clone https://github.com/ay-lab/dcHiC
cd dcHiC
conda env create -f ./packages/dchic.yml
conda activate dchic
cd packages
R CMD INSTALL functionsdchic_1.0.tar.gz

Out:

... fatal error: BMAcc.h: No such file or directory
   12 | #include <BMAcc.h>
      |          ^~~~~~~~~
compilation terminated...
papelypluma commented 2 years ago

Hi @ay-lab. Thanks for looking into this. I followed exactly the steps and commands for conda just like what @The-Hungry-Caterpillar did.

ay-lab commented 2 years ago

Hi all,

Thank you all for the notice and for using our tool. The issue seemed to be with the way that some header files were defined/included. Can you try the new file below? I tested it on Mac and Linux machines and it finished successfully.

functionsdchic_1.0.tar.gz

papelypluma commented 2 years ago

Hi @ay-lab. Thank you for sharing the file with us. It worked!

The-Hungry-Caterpillar commented 2 years ago

It works for me, too @ay-lab. Thank you so much!

ay-lab commented 2 years ago

Awesome—will push to main repo now!