ay-lab / fithic

Fit-Hi-C is a tool for assigning statistical confidence estimates to chromosomal contact maps produced by genome-wide genome architecture assays such as Hi-C.
MIT License
79 stars 16 forks source link

Merge filter generalizable? #27

Closed jessakay closed 4 years ago

jessakay commented 4 years ago

Having multiple adjacent bin pairs all passing some constant significance threshold despite stemming from the same underlying interaction can be an issue in quite a number of other Hi-C analyses, for instance in calling differential interactions by SELFISH as implemented by your group.

The merging filer introduced here seems like a nice approach to this problem, but I was curious if there has been any testing done on whether such a method is suited to prune the output of other tools?

Thanks!

ay-lab commented 4 years ago

Hi, yes, the idea and any other similar approach for local filtering can and should be applicable to other Hi-C analyses as you are suggesting. However, for SELFISH and for a new tool we recently released (Mustache) this would not be needed at all because they already handle the dependency between neighboring pixels and implement their own local filters. We haven't tried but it is very likely that the merging filter will make no difference at all in their results. Thanks for the suggestion.

On Thu, Feb 27, 2020 at 12:30 AM jessakay notifications@github.com wrote:

Having multiple adjacent bin pairs all passing some constant significance threshold despite stemming from the same underlying interaction can be an issue in quite a number of other Hi-C analyses, for instance in calling differential interactions by SELFISH as implemented by your group.

The merging filer introduced here seems like a nice approach to this problem, but I was curious if there has been any testing done on whether such a method is suited to prune the output of other tools?

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ay-lab/fithic/issues/27?email_source=notifications&email_token=AEJTNJHNSFXUITVQW7YKVYTRE522JA5CNFSM4K4WHYSKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IQWTGOA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEJTNJE7GLILUALET6RP4ZTRE522JANCNFSM4K4WHYSA .