Closed HoshinoTented closed 2 weeks ago
Do you intend to supersede ModuleExport
with ModuleExport2
? (and also the other similarly named classes)
Do you intend to supersede
ModuleExport
withModuleExport2
? (and also the other similarly named classes)
Yes, I keep it because I am too lazy to delete it.
The code compiles. However, there are some problems: We have a lot of usage of import xxx::base
, and they cause name conflicts since the name base
.
Well, a lot of code is reverted cause:
ModuleName.Qualified
as the name of module (see last comment)ResolveInfo
can tell)However, I found an unnatural place in CompiledModule::SerExport
, and I fixed it in this PR.
Attention: Patch coverage is 83.16832%
with 34 lines
in your changes missing coverage. Please review.
Project coverage is 79.77%. Comparing base (
8f52aab
) to head (5bbf969
). Report is 21 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
bors r+
This PR redesigned the module system:
import data::nat
can be referred bynat
rather thandata::nat
, soUseHide.Name
should store a single string rather thanQualifiedID