search

aya-prover / aya-dev

A proof assistant and a dependently-typed language
https://www.aya-prover.org
MIT License
281 stars 16 forks source link

Reviewing Code, More Documents and Make Notes for Module System #1137

Closed HoshinoTented closed 4 days ago

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (54ce153) to head (d119f57). Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
...se/src/main/java/org/aya/normalize/Normalizer.java 80.00% 0 Missing and 1 partial :warning:
...c/main/java/org/aya/resolve/context/Candidate.java 50.00% 0 Missing and 1 partial :warning:
...in/java/org/aya/resolve/context/ModuleContext.java 0.00% 1 Missing :warning:
.../java/org/aya/syntax/concrete/stmt/ModuleName.java 50.00% 1 Missing :warning:
...java/org/aya/syntax/concrete/stmt/StmtVisitor.java 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1137 +/- ## ========================================= Coverage 79.77% 79.77% - Complexity 3356 3359 +3 ========================================= Files 307 307 Lines 10158 10163 +5 Branches 1220 1221 +1 ========================================= + Hits 8104 8108 +4 + Misses 1388 1387 -1 - Partials 666 668 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ice1000 commented 4 days ago

CI fails

HoshinoTented commented 4 days ago

Seems we didn't check isAmbiguous somewhere.