search

aya-prover / aya-vscode

~ VSCode extension for Aya Prover
GNU General Public License v3.0
7 stars 2 forks source link

Upgrade dependencies #11

Closed ice1000 closed 2 years ago

ice1000 commented 2 years ago

bors r+

ice1000 commented 2 years ago

What!?

I couldn't believe that a dependency upgrade would affect so much lines like this

bors[bot] commented 2 years ago

Build failed:

by-cloud commented 2 years ago

because --jar in args

ice1000 commented 2 years ago

because --jar in args

Really??

ice1000 commented 2 years ago

because --jar in args

I guess it's because I didn't update "engines.vscode" in package.json, let's try again

ice1000 commented 2 years ago

bors r+

bors[bot] commented 2 years ago

Build succeeded:

ice1000 commented 2 years ago

Build succeeded:

Thanks!

ice1000 commented 2 years ago

Well, let's be nice, but I indeed believe that there's a better way around. It's the price we pay for tracking a lock file in the version control system anyway, we have the option to don't include that file

ice1000 commented 2 years ago

We can just avoid bumping the deps too often. Like when we have a lot of new changes, we upgrade deps, or before each release (when we have releases in the future), we upgrade deps.

imkiva commented 2 years ago

We can just avoid bumping the deps too often. Like when we have a lot of new changes, we upgrade deps, or before each release (when we have releases in the future), we upgrade deps.

Great idea!