search

aya-prover / aya-vscode

~ VSCode extension for Aya Prover
GNU General Public License v3.0
7 stars 2 forks source link

MISC: use pnpm #7

Closed dannypsnl closed 3 years ago

re-xyr commented 3 years ago

The build script is still using yarn. Could you change it to use pnpm too?

dannypsnl commented 3 years ago

Get it

dannypsnl commented 3 years ago

It seems like we need to install pnpm back to upstream(npm cannot read installation by pnpm thus my fixed won't work

dannypsnl commented 3 years ago

@re-xyr I have done the patch to lannonbr/vsce-action@master, could you approve CI?

ice1000 commented 3 years ago

It should be running

ice1000 commented 3 years ago

Failed

dannypsnl commented 3 years ago

Failed

I see, stupid error. package.json be reverted but I didn't update it again.

dannypsnl commented 3 years ago

NOTE: to fix

ERROR: This version of pnpm requires at least Node.js v12.17 11 The current version of Node.js is v10.24.1

ice1000 commented 3 years ago

Do we really need these much dependencies? I wonder if we can simplify the lock files

re-xyr commented 3 years ago

It is the vscode language client that needs that many dependencies, and we depend on the language client. And it is better to lock all the dependencies’ versions to have reproducible builds.

ice1000 commented 3 years ago

Ok

ice1000 commented 3 years ago

Fuck JavaScript ecosystem

re-xyr commented 3 years ago

Speaking of the lock files, I believe Java build systems forces you to have one exact version for a dependency so you don’t need lock files. Haskell stack is crazier, for each LTS ghc version it has a giant lock file that locks all packages versions stored in stackage, and this giant lock file is referred to by an LTS version number, so you don’t need lock files for each of your project.

dannypsnl commented 3 years ago

need to rerun, I use node:12-slim in dannypsnl-fork/vsce-action now

ice1000 commented 3 years ago

You can push an empty commit. I decide to squash this so do whatever you want!

dannypsnl commented 3 years ago

You can push an empty commit. I decide to squash this so do whatever you want!

updated, CI

dannypsnl commented 3 years ago

try install vsce by pnpm, CI

ice1000 commented 3 years ago

Check failed

dannypsnl commented 3 years ago 
> aya-prover-vscode@0.0.1 compile /github/workspace
> tsc -p ./

 ERROR  Command failed: npm list --production --parseable --depth=99999 --loglevel=error
npm ERR! missing: minimatch@^3.0.4, required by vscode-languageclient@7.0.0
npm ERR! missing: semver@^7.3.4, required by vscode-languageclient@7.0.0
npm ERR! missing: vscode-languageserver-protocol@3.16.0, required by vscode-languageclient@7.0.0

emmm....but there shall not have any call to npm.

ice1000 commented 3 years ago

😥