aya49 / flowGraph

Accurately selects cell populations features that differentiate between flow cytometry sample classes by removing top-down dependency between features modelled on a lattice.
https://aya49.github.io/2020/09/30/flowGraph/
0 stars 1 forks source link

NOTICE: plan(multiprocess) of future is deprecated #1

Closed HenrikBengtsson closed 2 years ago

HenrikBengtsson commented 3 years ago

Hi.

This is a friendly reminder that plan(multiprocess) of the future package is deprecated since future 1.20.0 (2020-11-03). It will eventually become defunct and removed. The background for this can be found in https://github.com/HenrikBengtsson/future/issues/420.

Your flowGraph package relies on multiprocess, cf. https://github.com/aya49/flowGraph/search?q=multiprocess.

Please migrate your code to the platform-independent plan(multisession) or the Linux/macOS-specific plan(multicore). If you want to emulate what multiprocess does, you can do something like:

  if (parallelly::supportsMulticore()) {
    oplan <- plan(multicore)
  } else {
    oplan <- plan(multisession)
  }
  on.exit(plan(oplan))

BTW, if you don't already do so, please make sure to undo any plan() you set in your code, as illustrated by the above example. This is needed to guarantee that calling your code won't override settings that the user has set previously. You can read about this in https://future.futureverse.org/reference/plan.html#for-package-developers.

Thank you,

Henrik (maintainer of the future package)

aya49 commented 2 years ago

Thank you for the update. plan(multiprocess) changed to plan(multisession).

HenrikBengtsson commented 2 years ago

FYI, you still mention 'multiprocess' in a source-code comment of one of your example():s;

https://github.com/aya49/flowGraph/blob/78a1332746521dadd736bc92148f589c55a40133/R/00_helpers.R#L35-L53

aya49 commented 2 years ago

Thank you Henrik!