resolving issue #45 - Githubissues

ayaankhan98 / bigINT

Efficient OpenSource Big Integer(Library) Support for C++

Boost Software License 1.0

6 stars 26 forks source link

resolving issue #45 #46

Closed yashsoni501 closed 4 years ago

yashsoni501 commented 4 years ago

Description of Change

The this->number was re-initialized in case of negative numbers. resolving #45

Checklist

[x] Added description of change
[x] PR title follows semantic
[x] Search previous suggestions before making a new one, as yours may be a duplicate.

ayaankhan98 commented 4 years ago

Thanks for your contribution! @yashsoni501 can you please add tests for this behaviour.

yashsoni501 commented 4 years ago

@ayaankhan98 the test for this already exists under bigINT/tests/operators/ostream_test.cpp I manually checked for both the versions over this test. The test fails for the code before commit and passes after.

ayaankhan98 commented 4 years ago

@yashsoni501 i know tests are there for ostream operator, what i mean is that this wrong behaviour is triggered due to error is ctor so there must be some issue with the ctor tests that is not considered while writing the tests for ctors. therefore the tests for ctor are weak kindly update those tests to cover all possible aspects.