ayaankhan98 / bigINT

Efficient OpenSource Big Integer(Library) Support for C++
Boost Software License 1.0
6 stars 26 forks source link

configure ctests and cmake #5

Closed ayaankhan98 closed 4 years ago

VinWare commented 4 years ago

One problem I faced is that the CMake file in tests/operators seems to take absolute paths, so it wasn't building. By commenting out AUX_SOURCE_DIRECTORY and the file statement for C files, the issue was resolved. I'll make a PR about this if you want

ayaankhan98 commented 4 years ago

yes sure, current cmake setup is not correct. tests are also not building. if you wish to take this issue, go ahead. i have no problem

VinWare commented 4 years ago

OK, I'll first do this then look into the overloading

AhsanAAR commented 4 years ago

I don't know much about Cmake. Can I start working on bigINT directly ??

ayaankhan98 commented 4 years ago

@AhsanAAR yes you can work, it's not necessary to know each and everything, look at the issues if you think you can work on any of these just mention there that you are working and go ahead

AhsanAAR commented 4 years ago

@ayaankhan98 got it. But won't I be needing it to test my cases

ayaankhan98 commented 4 years ago

@AhsanAAR No CMake is not about testing, it a tool to build the project. soon we will have automated infrastructure for building project, running tests, checking code quality and code formatting. so you do not need to worry about this.

AhsanAAR commented 4 years ago

@ayaankhan98 okaa. Btw there's an issue here with gcc please take a look into this

image

ayaankhan98 commented 4 years ago

@AhsanAAR @VinWare project structure is reconfigured and automated test and build process is also enabled now, please pull the latest changes to your fork, otherwise your PR's will have merge conflicts

AhsanAAR commented 4 years ago

@ayaankhan98 this problem is pertaining. it's registering int64_t and long long as the same thing

ayaankhan98 commented 4 years ago

@AhsanAAR yes they are same, this is a bug in class definition. see #16

AhsanAAR commented 4 years ago

@ayaankhan98 ohkay. I'll try and resolve this issue and make a PR asap

AhsanAAR commented 4 years ago

@ayaankhan98 which build tool do I have to use in Cmake. Sorry if these are dumb questions I'm a bit new to open-source. But I have made a whole big float class so I can help :)

ayaankhan98 commented 4 years ago

@ayaankhan98 which build tool do I have to use in Cmake. Sorry if these are dumb questions I'm a bit new to open-source. But I have made a whole big float class so I can help :)

please have a look at the readme.md

VinWare commented 4 years ago

OK works now!